Speedup travis install src test #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Apr 9, 2017
.travis.yml
Outdated
| @@ -31,6 +31,7 @@ script: | |||
| - if [ -n "${SHELLCHECK-}" ]; then shellcheck -s bash nvm.sh && shellcheck -s sh nvm.sh && shellcheck -s dash nvm.sh && shellcheck -s ksh nvm.sh ; fi | |||
| - if [ -n "${SHELLCHECK-}" ]; then shellcheck -s bash install.sh bash_completion nvm-exec ; fi | |||
| - if [ -n "${SHELL-}" ] && [ -n "${TEST_SUITE}" ]; then make TEST_SUITE=$TEST_SUITE URCHIN="$(npm bin)/urchin" test-$SHELL ; fi | |||
| - if [ -n "$WITHOUT_CURL" ]; then sudo apt-get install curl -y ; fi | |||
There was a problem hiding this comment.
Perhaps you mean to run this in after_success, so it only runs once, and so it's not part of "script"?
There was a problem hiding this comment.
Okay, sure, but I have to say, there are more things mixed here so sometimes I really don't know which one would you prefer to use.
There was a problem hiding this comment.
things that are tests go in "script" - things that are setup go in a "before" step - things that are cleanup, or things like "aggregate coverage from all jobs" go in "after success".
PeterDaveHello
force-pushed
the
speedup-travis-install-src-test
branch
from
6404678 to
8a02606
Compare
|
Done. |
ljharb
approved these changes
Apr 13, 2017
ljharb
force-pushed
the
speedup-travis-install-src-test
branch
from
8a02606 to
7aa3448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1489, Travis CI cache needs
curl