Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving the python_module_tools before the SRF import #87

Merged
1 commit merged into from
Jun 28, 2022
Merged

Moving the python_module_tools before the SRF import #87

1 commit merged into from
Jun 28, 2022

Conversation

mdemoret-nv
Copy link
Contributor

Fixes #86

If the python_module_tools is after find_package(SRF), the build fails. Unclear why, but this fixes it.

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jun 28, 2022
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 28, 2022 17:49
@drobison00
Copy link
Contributor

SRF uses python module tools as well; probably something in the cmake file that ends up being relative to the package.

@mdemoret-nv mdemoret-nv linked an issue Jun 28, 2022 that may be closed by this pull request
[BUG] Quickstart Doesnt Compile with SRF Conda Package #86
Closed
@mdemoret-nv
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit fe24d00 into nv-morpheus:branch-22.06 Jun 28, 2022
@mdemoret-nv mdemoret-nv deleted the mdd_fix-quickstart-compile branch June 28, 2022 20:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanolson ryanolson ryanolson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Quickstart Doesnt Compile with SRF Conda Package
3 participants
@mdemoret-nv @drobison00 @ryanolson