Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NVML + MIG Behavior #206

Merged
2 commits merged into from
Nov 4, 2022
Merged

Conversation

ryanolson
Copy link
Contributor

@ryanolson ryanolson commented Oct 31, 2022

This resolves #124 when using 1 or more standard GPU devices. When multiple GPUs are visible, all MIG devices are ignored.

Issue #205 will enable running on MIG instances under the strict condition that the only visible devices is in MIG mode and that there is only 1 visible MIG instances seen by the calling processes.

Code coverage is expected to decrease because we have no MIG instances in CI.

@ryanolson ryanolson added the non-breaking Non-breaking change label Oct 31, 2022
@ryanolson ryanolson requested review from a team as code owners October 31, 2022 01:31
@ryanolson ryanolson self-assigned this Oct 31, 2022
@ryanolson ryanolson added review: ready improvement Improvement to existing functionality labels Oct 31, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 37.96% // Head: 37.96% // No change to project coverage 👍

Coverage data is based on head (7edc0fa) compared to base (a889138).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-22.11     #206   +/-   ##
=============================================
  Coverage         37.96%   37.96%           
=============================================
  Files               101      101           
  Lines              2439     2439           
  Branches           1144     1144           
=============================================
  Hits                926      926           
  Misses              716      716           
  Partials            797      797           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement from the current user experience.

@ryanolson
Copy link
Contributor Author

ryanolson commented Nov 4, 2022

@gpucibot merge

1 similar comment
@ryanolson
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit fd0c7c4 into nv-morpheus:branch-22.11 Nov 4, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] SRF on MIG error
3 participants