Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Options #111

Merged
67 commits merged into from
Jul 13, 2022
Merged

Network Options #111

67 commits merged into from
Jul 13, 2022

Conversation

ryanolson
Copy link
Contributor

@ryanolson ryanolson commented Jul 2, 2022 •
edited
Loading

Fixes #96
Fixes #55
Fixes #138

  • improves the behavior of set_dedicated_network_thread
  • restores test_options.cpp my merging those tests into the topology aware test_partitions.cpp
    • this is an improvement over the older tests because they now run against the fixture topology rather than the topology of whatever machine happens to be running the tests.

ryanolson added 30 commits June 16, 2022 21:11
@ryanolson
remove shared_ptr creep in system and resources
8ab6473
@ryanolson
re-enable test_runnable
e740aa2
@ryanolson
re-enable internal tests
780be79
@ryanolson
adding system::IResource to enable external thread initializers/final…
358b992 
…izers
@ryanolson
update python to create a system::IResource to initializer the executor
15ee92c
@ryanolson
iwyu
559000f
@ryanolson
removed old code
8014e6b
@ryanolson
merge main
9bec540
@ryanolson
iwyu
4ffc80e
@ryanolson
checkpoint
e05fd8d
@ryanolson
adding missing copyright header
dad1387
@ryanolson
adding network resources and re-enabling data_plane::Server
58c1649
@ryanolson
adding cpp files to build
a26bb6e
@ryanolson
fixing missing class method that results in unresovled external; clea…
5f3ea5b 
…n up headers
@ryanolson
merge updates from resource_management
a0f7c68
@ryanolson
checkpoint
2db7fba
@ryanolson
partition resources
a7cde72
@ryanolson
starting tests for network
350f5b1
@ryanolson
checkpoint
ec957da
@ryanolson
checkpoint
3a63933
@ryanolson
checkpoint
5615a03
@ryanolson
logging and arena resources seem to be working; resources::Manager bu…
dcc1900 
…ilding runnable, ucx and host memory resources
@ryanolson
increase log levels
9591532
@ryanolson
merge branch-22.08
e8363c5
@ryanolson
missing files
56c584a
@ryanolson
deleted old files left from merge
6503b11
@ryanolson
removed file
4a7b1fd
@ryanolson
moving test_memory to internal tests; adding direct registration reso…
e819f89 
…urce for device memory
@ryanolson
adding direct registration resource for device memory
291ac6f
@ryanolson
remove <cuda/memory_resource>
0ea1f51
ryanolson and others added 16 commits June 28, 2022 22:39
@ryanolson
added dedicated main / dedicated network threads test
b7bde9e
@ryanolson
ef7
73d6f70
@ryanolson
ef8
c391522
@ryanolson
ef9
68c34d0
@ryanolson
ef10
efc43d8
@ryanolson
complete test_options -> test_partitions migration
f470157
@ryanolson
ucx::RegisteredResource is generally only used by device resources; a…
cc1c535 
…dding cuda_device_id to the constructor so we can properly set the device id when registering memory
@ryanolson
transient pool - initial commmit
0887b3f
@ryanolson
add transient deconstruction to ensure the destructor on T is called
cced88a
@ryanolson @dagardner-nv
Update src/internal/memory/transient_pool.hpp
ef4d2a2 
Co-authored-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
@ryanolson
adding comments
515cab8
@ryanolson
Merge branch 'transient_pool' of github.com:ryanolson/SRF into transi…
4d5feee 
…ent_pool
@ryanolson
default move constructors do not play nice with raw pointers; adding …
665047c 
…explicit move constructors and assignment operators and extending the test coverage to ensure the proper behavior; also added parameter pack to construct an object T for an await_object<T>(some, set, of, args)
@ryanolson
merge main (branch-22.08)
0b124eb
@ryanolson
adding comments to explain the transient tests
9c0f53b
@ryanolson
Merge branch 'transient_pool' into network_thread
5ca433e
@ryanolson ryanolson requested review from a team as code owners July 2, 2022 04:10
@ryanolson ryanolson self-assigned this Jul 2, 2022
@ryanolson ryanolson added non-breaking Non-breaking change feature request New feature or request ready for review labels Jul 2, 2022
@ryanolson ryanolson added this to the Multi-Node Support milestone Jul 2, 2022
mdemoret-nv
mdemoret-nv approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what most of it does, but I dont see anything wrong with the code

@ryanolson
Copy link
Contributor Author

We can use code review time tomorrow to discuss. I'll elaborate the description of the PR

@ryanolson
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit 104fcbf into nv-morpheus:branch-22.08 Jul 13, 2022
@ryanolson ryanolson deleted the network_thread branch July 13, 2022 06:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@ryanolson ryanolson

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
MRC Boards
Status: Done
Milestone
Multi-Node Support
2 participants
@ryanolson @mdemoret-nv