[REVIEW] SRF README Update - In Preparation of Public Release #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
awthomp
commented
Jun 27, 2022
awthomp
commented
- Adding anatomy of a SRF pipeline image
- Adding instructions on how to install SRF
- Clarifications / style updates
|
Pull requests from external contributors require approval from a |
ryanolson
added
improvement
ryanolson
reviewed
Jun 28, 2022
ryanolson
reviewed
Jun 28, 2022
ryanolson
approved these changes
Jun 28, 2022
awthomp
changed the title
|
@ryanolson -- I think this is good to merge barring other comments/suggestions. |
|
@gpucibot merge |
ghost
merged commit
mdemoret-nv
pushed a commit
to mdemoret-nv/MRC
that referenced
this pull request
Jun 28, 2022
- Adding anatomy of a SRF pipeline image - Adding instructions on how to install SRF - Clarifications / style updates Authors: - Adam Thompson (https://github.com/awthomp) Approvers: - Ryan Olson (https://github.com/ryanolson) URL: nv-morpheus#78 (cherry picked from commit 8d70275)
ghost
pushed a commit
that referenced
this pull request
Jun 28, 2022
Originally from #78 but was applied to the wrong branch. Applying it instead to `branch-22.06` Authors: - Michael Demoret (https://github.com/mdemoret-nv) - Adam Thompson (https://github.com/awthomp) Approvers: - Devin Robison (https://github.com/drobison00) URL: #93
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.