Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing RAPIDS_VERSION to SRF_RAPIDS_VERSION #73

Merged

Conversation

mdemoret-nv
Copy link
Contributor

The latest Conda packages upgraded to RAPIDS CMake 22.06 which has a bug when trying to install UCX. It uses the following for the export set:

find_package(ucx 1.12 QUIET)
find_dependency(ucx)

The ucx installed package doesnt check for existing targets so the second call to find_dependency fails with an error. This explicitly sets: rapids_export_package which will change the export set to:

find_dependency(ucx)

This also resolves many hidden issues by renaming the variable RAPIDS_VERSION to SRF_RAPIDS_VERSION.

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jun 27, 2022
@mdemoret-nv mdemoret-nv requested review from a team as code owners June 27, 2022 06:42
@mdemoret-nv mdemoret-nv changed the base branch from branch-22.08 to branch-22.06 June 27, 2022 06:43
@mdemoret-nv
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit 614cbaa into nv-morpheus:branch-22.06 Jun 27, 2022
@mdemoret-nv mdemoret-nv deleted the mdd_fix-rapids-cmake-version branch June 27, 2022 15:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants