Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPP checks for CI #147

Merged
18 commits merged into from
Jul 25, 2022
Merged

Fix CPP checks for CI #147

18 commits merged into from
Jul 25, 2022

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jul 15, 2022 •
edited
Loading

Fixes the determination of the changed files list.
Adds IWYU to CI.

Fixes #148

@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement labels Jul 15, 2022
@dagardner-nv dagardner-nv requested a review from a team as a code owner July 15, 2022 22:14
@dagardner-nv dagardner-nv requested a review from a team as a code owner July 15, 2022 22:43
@dagardner-nv dagardner-nv changed the title Draft: Testing CI Fix CPP checks for CI Jul 15, 2022
mdemoret-nv
mdemoret-nv approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with changes

ci/scripts/jenkins/checks.sh Outdated Show resolved Hide resolved
ci/scripts/jenkins/checks.sh Outdated Show resolved Hide resolved
ci/scripts/jenkins/checks.sh Outdated Show resolved Hide resolved
@dagardner-nv
Copy link
Contributor Author

rerun tests

@dagardner-nv
Copy link
Contributor Author

rerun tests

@jarmak-nv jarmak-nv added improvement Improvement to existing functionality and removed improvement labels Jul 22, 2022
@dagardner-nv
Copy link
Contributor Author

rerun tests

@dagardner-nv dagardner-nv added improvement Improvement to existing functionality and removed improvement Improvement to existing functionality labels Jul 25, 2022
@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit e5dd099 into nv-morpheus:branch-22.08 Jul 25, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] IWYU checks broken/disabled in CI
3 participants
@dagardner-nv @mdemoret-nv @jarmak-nv