Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas for cpp example ex00_simple_pipeline #106

Merged
3 commits merged into from
Jul 11, 2022

Conversation

matt-stack
Copy link
Contributor

These are some ideas I had after going through ex00

@matt-stack matt-stack requested a review from a team as a code owner June 30, 2022 01:59
@ghost
Copy link

ghost commented Jun 30, 2022

Pull requests from external contributors require approval from a nv-morpheus organization member with write or admin permissions before CI can begin.

@matt-stack
Copy link
Contributor Author

And for ex02, All I think needs change is to make it match the output of ex00, which is 2.5f * data rather than 2 * data as a float. Then make same switch in the expected output in README

@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement labels Jun 30, 2022
@dagardner-nv
Copy link
Contributor

ok to test

@matt-stack
Copy link
Contributor Author

matt-stack commented Jul 1, 2022

@ryanolson- Made the changes we discussed yesterday

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 9fbf247 into nv-morpheus:branch-22.08 Jul 11, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants