Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): add runtime check to filter plugins in dependsOn #25409

Merged
merged 1 commit into from
Jan 27, 2024
Merged

fix(nuxt): add runtime check to filter plugins in dependsOn #25409

merged 1 commit into from
Jan 27, 2024

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Jan 23, 2024 •
edited
Loading

🔗 Linked issue

#25401

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hey 👋 This PR adds a runtime check on dependsOn.

There's another possibility of build time but i think a runtime check is still needed.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Jan 23, 2024
@huang-julien
Copy link
Member Author

I'm removing the "fix" to avoid closing the issue. I'd like to move the issue to the team board before closing it through this PR

@danielroe danielroe merged commit de0ceaa into main Jan 27, 2024
35 of 36 checks passed
@danielroe danielroe deleted the fix/unexisting_plugin branch January 27, 2024 22:14
@github-actions github-actions bot mentioned this pull request Jan 27, 2024
Merged
@Barbapapazes Barbapapazes mentioned this pull request Feb 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huang-julien @danielroe @DamianGlowala