fix(nuxt): add router.options files in definite order #25397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Merged
| @@ -38,10 +38,10 @@ export default defineNuxtModule({ | |||
| // Add default options | |||
| context.files.push({ path: resolve(runtimeDir, 'router.options'), optional: true }) | |||
|
|
|||
| await Promise.all(nuxt.options._layers.map(async layer => { | |||
| for (const layer of nuxt.options._layers) { | |||
There was a problem hiding this comment.
Couldn't we use await Promise.all and then loop over the resolved promises?
There was a problem hiding this comment.
Oops, yes, we could indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
In debugging https://github.com/nuxt/nuxt/actions/runs/7628326647/job/20779171448?pr=25395, realised that we in fact were resolving
app/router.optionsfiles in a non-reproducible order (since #24922).📝 Checklist