This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
feat(nuxt): deep watch useCookie ref value by default
#9664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@xtoolkit is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
pi0
reviewed
Dec 12, 2022
|
Sorry for my bad English. please rewrite document ... |
pi0
reviewed
Dec 12, 2022
| @@ -15,6 +15,7 @@ export interface CookieOptions<T = any> extends _CookieOptions { | |||
| decode?(value: string): T | |||
| encode?(value: T): string | |||
| default?: () => T | Ref<T> | |||
| watch?: boolean | 'deep' | 'shallow' | |||
There was a problem hiding this comment.
Suggested change
| watch?: boolean | 'deep' | 'shallow' | |
| watch?: false | 'deep' | 'shallow' |
There was a problem hiding this comment.
I think better keep boolean type. Because it maybe passed by variable.
export function useCookieTest(watch: boolean) {
const test = useCookie('test', {}, {watch})
const change = () => {test.value = 100}
return {change}
}|
|
||
| Specifies the `boolean` or `string` value for [watch](https://vuejs.org/api/reactivity-core.html#watch) cookie ref data. | ||
|
|
||
| - `true` or `shallow` will watch cookie ref data. |
There was a problem hiding this comment.
Suggested change
| - `true` or `shallow` will watch cookie ref data. | |
| - `shallow` will watch cookie ref data. |
|
@danielroe Do you agree to making default behavior deep watching cookie value or any merits to keep it one level by default? |
|
Agreed - I think deep behaviour is more intuitive. 👍 |
pi0
changed the title
useCookie ref value by default
danielroe
reviewed
Dec 12, 2022
danielroe
reviewed
Dec 12, 2022
xtoolkit
commented
Dec 12, 2022
Merged
danielroe
added a commit
that referenced
this pull request
Jan 21, 2023
* feat(nuxt): useCookie add deep watch option * docs(api): useCookie add deepWatch option * feat(nuxt): useCookie change deepWatch to watch option * boolean|shallow * enable watch by default * docs: fix example * docs(api): update useCookie example Co-authored-by: Pooya Parsa <pooya@pi0.io> Co-authored-by: Daniel Roe <daniel@roe.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
useCookieonly change when.valueupdate. we can use deep flag in watch and track all change.📝 Checklist