Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(test-utils): do not hide Vitest output #9442

Merged
merged 4 commits into from
Dec 2, 2022
Merged

fix(test-utils): do not hide Vitest output #9442

merged 4 commits into from
Dec 2, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Nov 30, 2022

πŸ”— Linked issue

close nuxt/nuxt#15747

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

kit.logger.level was overriding globally to hide all output including Vitest

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Nov 30, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@atinux
Copy link
Member

atinux commented Nov 30, 2022

Thanks!

Would it be possible also to add the others logs like mentioned in the issue?
CleanShot 2022-12-01 at 00 40 02@2x

@antfu antfu changed the title fix(test-utils): do not hide Vitest output, fix(test-utils): do not hide Vitest output Dec 1, 2022
@atinux atinux requested review from danielroe and pi0 December 1, 2022 15:02

export const setup = async () => {
kit.logger.info('Building Nuxt app...')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might to refactor this later into setup for fine gained control when to show message (build is not always happening / can include more context details in log)

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks πŸ’―

@pi0 pi0 merged commit 3501fd5 into main Dec 2, 2022
@pi0 pi0 deleted the fix/test-log branch December 2, 2022 09:42
@pi0 pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Vitest output when running nuxi test
4 participants