Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): backward compatibility for kit <= RC.10 without useNitro #7593

Merged
merged 2 commits into from
Sep 16, 2022
Merged

fix(nuxi): backward compatibility for kit <= RC.10 without useNitro #7593

merged 2 commits into from
Sep 16, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

If used with an older version of kit without the feature it will error out on:

 ERROR  useNitro is not a function

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working cli ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Sep 16, 2022
@danielroe danielroe requested a review from pi0 September 16, 2022 11:59
@danielroe danielroe self-assigned this Sep 16, 2022
@netlify
Copy link

netlify bot commented Sep 16, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 759c4b6
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6324b2029aa6410009c4c8c1
😎 Deploy Preview https://deploy-preview-7593--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 changed the title fix(nuxi): compat with old versions of kit fix(nuxi): backward compatibility for kit <= RC.10 without useNitro Sep 16, 2022
@pi0 pi0 merged commit 2b57bfe into main Sep 16, 2022
@pi0 pi0 deleted the fix/kit-nitro-fallback branch September 16, 2022 17:27
@pi0 pi0 mentioned this pull request Sep 20, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working cli ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0