Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxi): auto-generate .npmrc and setting for pnpm #7407

Merged
merged 7 commits into from
Nov 11, 2022

Conversation

kecrily
Copy link
Contributor

@kecrily kecrily commented Sep 11, 2022

πŸ”— Linked issue

ref nuxt/nuxt#14146

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Before we support using pnpm without --shamefully-hoist, let's automatically generate .npmrc for an out-of-the-box experience. Remove it after support.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 11, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 6f5bdb1
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636d26c071251100088e9e50
😎 Deploy Preview https://deploy-preview-7407--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0
Copy link
Member

pi0 commented Sep 12, 2022

I really love the idea of this PR! But I think which-pm-runs only works when running nuxi init with pnpm and in docs we also use npx which could be misleading if someone uses npx + pnpm install.

@kecrily
Copy link
Contributor Author

kecrily commented Sep 12, 2022

This is really a problem. Maybe we can clarify this in the documentation?

@pi0 pi0 force-pushed the main branch 2 times, most recently from 247e18b to c98e5c7 Compare September 14, 2022 10:41
@danielroe danielroe changed the title chore: auto gengerate .npmrc and setting for pnpm feat: auto-generate .npmrc and setting for pnpm Nov 10, 2022
@danielroe danielroe changed the title feat: auto-generate .npmrc and setting for pnpm feat(nuxi): auto-generate .npmrc and setting for pnpm Nov 10, 2022
@pi0 pi0 merged commit 2f53495 into nuxt:main Nov 11, 2022
@pi0 pi0 mentioned this pull request Nov 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
danielroe pushed a commit that referenced this pull request Jan 21, 2023
Co-authored-by: Pooya Parsa <pooya@pi0.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants