This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
chore: add yarn plugins #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was an intentional for first trying yarn2 + node_modules linker without plugins. And to be honest I'm not fan of version controlling external content since over the time makes git history big... For this PR, i think we should only version-control what is necessary for yarn in a include-basis rather than excluded subdirs |
|
(@danielroe correction: i think adding plugins was good. my comment was about gitignore pattern) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR versions the yarn binary (which yarn does itself when running
yarn set version berryfor the second time after converting a repo to use yarn v2) and adds two yarn plugins:When we need to upgrade yarn we can manually add the changes to git rather than using the excluded subdirs pattern here as @pi0 recommends below.