Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): use buildAssetsURL for dynamic imports #4844

Merged
merged 1 commit into from
May 6, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#13637, resolves nuxt/nuxt#13841

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We were wrongly using directory (/_nuxt) and not URL which adds it to the baseURL/cdnURL.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels May 6, 2022
@danielroe danielroe requested a review from pi0 May 6, 2022 10:42
@danielroe danielroe self-assigned this May 6, 2022
@netlify
Copy link

netlify bot commented May 6, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 383cf61
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6274fbaa502669000874b55d

@pi0 pi0 merged commit 4079882 into main May 6, 2022
@pi0 pi0 deleted the fix/build-assets branch May 6, 2022 10:51
@pi0 pi0 mentioned this pull request May 6, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS assets are pulling twice when use app.cdnURL assets loaded with different URLs with custom baseURL
2 participants