This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt3): directly emit document.template.mjs
#4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
Apr 14, 2022
packages/nuxt3/src/core/nitro.ts
Outdated
| @@ -196,13 +195,16 @@ async function resolveHandlers (nuxt: Nuxt) { | |||
| async function writeDocumentTemplate (nuxt: Nuxt) { | |||
| // Compile html template | |||
| const src = resolve(nuxt.options.buildDir, 'views/app.template.html') | |||
| const dst = src.replace(/.html$/, '.mjs').replace('app.template.mjs', 'document.template.mjs') | |||
| const dst = resolve(nuxt.options.buildDir, 'views/document.template.mjs') | |||
There was a problem hiding this comment.
Since we splitted bridge implementation, I think now we could initially generate .mjs version from nuxt templates rather than copy and convert.
danielroe
changed the title
pi0
approved these changes
Apr 15, 2022
pi0
changed the title
document.template.mjs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#13741
❓ Type of change
📚 Description
In development, there's a danger of breaking the nitro build when we write the document template. As we've split bridge implementation off separately, we can instead write it directly.
📝 Checklist