fix(nuxt3): render nuxt custom error page #4289

danielroe · 2022-04-12T11:41:42Z

🔗 Linked issue

resolves nuxt/nuxt#13699

❓ Type of change

📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality like performance)
✨ New feature (a non-breaking change that adds functionality)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Follow up on nuxt/nuxt#13699.

📝 Checklist

I have linked an issue or discussion.
I have updated the documentation accordingly.

netlify · 2022-04-12T11:41:47Z

✅ Deploy Preview for nuxt3-docs canceled.

Name	Link
🔨 Latest commit	`4372e59`
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt3-docs/deploys/6255ddb3b7d36f00084dbc45

danielroe · 2022-04-12T12:12:56Z

@pi0 Given we use new defu in nitropack, we may have to bump bridge defu as well, but IIRC we had some breaking issues last time. WDYT?

pi0 · 2022-04-12T12:16:12Z

Given we use new defu in nitropack, we may have to bump bridge defu as well, but IIRC we had some breaking issues last time. WDYT?

Updating is fine as long as using default export instead of named one (until nuxt 2 also bumps defu. until then hosting can make issues)

danielroe · 2022-04-12T12:49:33Z

Note: we should add a breaking change indicator for bridge and require people to add the new version of defu to their package.json (as we now require this in nitropack 0.2.4) - or we need to revert this in nitropack.

danielroe · 2022-04-12T13:02:14Z

test/fixtures/bridge/package.json

@@ -7,6 +7,7 @@
  },
  "devDependencies": {
    "@nuxt/bridge": "*",
+    "defu": "^6.0.0",


Yes, that's right. v6 is already a direct dependency of @nuxt/bridge, and adding this directly in user's project is likely the best way to ensure top-level defu is v6.

pi0 · 2022-04-12T13:02:23Z

Note: we should add a breaking change indicator for bridge and require people to add the new version of defu to their package.json (as we now require this in nitropack 0.2.4) - or we need to revert this in nitropack.

I'm not sure about default hosting behavior with published package. Let's try on edge and see if there is a better way to enforce bridge using latest defu.

reverts 45ec2c8

packages/bridge/src/app.ts

packages/kit/src/module/define.ts

use new types and reveal error while generating error

fix(nuxt3): render nuxt custom error page

7646af9

danielroe added bug Something isn't working nitro nuxt3 ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Apr 12, 2022

danielroe requested a review from pi0 April 12, 2022 11:41

danielroe self-assigned this Apr 12, 2022

danielroe added 2 commits April 12, 2022 13:41

test: bump defu version in fixture

a542e00

fix: use errorHandler for bridge too

0f4d607

fix: remove nuxt3 line

6b4e505

pi0 mentioned this pull request Apr 12, 2022

chore(deps): update dependency nitropack to ^0.2.5 #4293

Closed

1 task

danielroe commented Apr 12, 2022

View reviewed changes

pi0 and others added 4 commits April 12, 2022 15:06

test: update fixtures

45ec2c8

fix: update snapshots

493aca9

reverts 45ec2c8

fix(bridge): use compat alias for defu

93da183

fix: used named export + alias

4d4a259

pi0 reviewed Apr 12, 2022

View reviewed changes

packages/bridge/src/app.ts Outdated Show resolved Hide resolved

pi0 reviewed Apr 12, 2022

View reviewed changes

packages/kit/src/module/define.ts Outdated Show resolved Hide resolved

danielroe and others added 6 commits April 12, 2022 16:44

fix: revert defu named imports

591a9ac

style: remove unused imports

b1b40ef

Merge branch 'main' into fix/override-nitro-error-page

40ddbd4

revert lockfile changes

58a87cb

update error.ts

04df227

use new types and reveal error while generating error

update nitropack

4372e59

pi0 merged commit e43ba6e into main Apr 12, 2022

pi0 deleted the fix/override-nitro-error-page branch April 12, 2022 20:37

danielroe added the 3.x label Jan 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(nuxt3): render nuxt custom error page #4289

fix(nuxt3): render nuxt custom error page #4289

danielroe commented Apr 12, 2022 •

edited

Loading

netlify bot commented Apr 12, 2022 •

edited

Loading

danielroe commented Apr 12, 2022 •

edited

Loading

pi0 commented Apr 12, 2022

danielroe commented Apr 12, 2022 •

edited

Loading

danielroe Apr 12, 2022

pi0 commented Apr 12, 2022

fix(nuxt3): render nuxt custom error page #4289

fix(nuxt3): render nuxt custom error page #4289

Conversation

danielroe commented Apr 12, 2022 • edited Loading

🔗 Linked issue

❓ Type of change

📚 Description

📝 Checklist

netlify bot commented Apr 12, 2022 • edited Loading

✅ Deploy Preview for nuxt3-docs canceled.

danielroe commented Apr 12, 2022 • edited Loading

pi0 commented Apr 12, 2022

danielroe commented Apr 12, 2022 • edited Loading

danielroe Apr 12, 2022

Choose a reason for hiding this comment

pi0 commented Apr 12, 2022

danielroe commented Apr 12, 2022 •

edited

Loading

netlify bot commented Apr 12, 2022 •

edited

Loading

danielroe commented Apr 12, 2022 •

edited

Loading

danielroe commented Apr 12, 2022 •

edited

Loading