fix(nuxt3): generate imports for components with named exports correctly #3288

danielroe · 2022-02-17T10:35:28Z

🔗 Linked issue

❓ Type of change

📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality like performance)
✨ New feature (a non-breaking change that adds functionality)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Previously we would always generate default imports for components, even though addComponent supports adding named imports. This PR adds support for that with genImport.

The change: (check review comments. Behavior change to be fixed for default export importing)

-  import __nuxt_component_23 from '/my/file/default.ts'
+  import { default as __nuxt_component_23 } from '/my/file/default.ts'
-  import __nuxt_component_24 from '/my/file/named.ts'
+  import { namedExport as __nuxt_component_24 } from '/my/file/named.ts'

Notes

I've added an example in with-components but it may be better in a unit test - let me know if so and I can extract...

📝 Checklist

I have linked an issue or discussion.
I have updated the documentation accordingly.

netlify · 2022-02-17T10:35:34Z

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: bfc4daf

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/620e589d5beebf0007fafba8

pi0 · 2022-02-17T13:49:21Z

examples/with-components/nuxt.config.ts

@@ -13,5 +14,14 @@ export default defineNuxtConfig({
        prefix: 'nuxt'
      }
    ]
+  },
+  hooks: {


It is probably not a generic use case to add in example. Let's have it in test/fixture/basic which can be used for actually testing behavior too.

pi0 · 2022-02-17T13:50:12Z

packages/nuxt3/src/components/loader.ts

@@ -37,7 +37,7 @@ function transform (content: string, components: Component[]) {
    if (component) {
      const identifier = map.get(component) || `__nuxt_component_${num++}`
      map.set(component, identifier)
-      imports += genImport(component.filePath, identifier)
+      imports += genImport(component.filePath, [{ name: component.export, as: identifier }])


Note: I guess we could improve genImport to avoid generating default as x when there is only one default import...

fix(nuxt3): generate imports for named exports correctly

a6c183e

danielroe added bug Something isn't working nuxt3 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Feb 17, 2022

danielroe requested a review from pi0 February 17, 2022 10:35

danielroe self-assigned this Feb 17, 2022

danielroe changed the title ~~fix(nuxt3): generate imports for named exports correctly~~ fix(nuxt3): generate imports for components with named exports correctly Feb 17, 2022

pi0 reviewed Feb 17, 2022

View reviewed changes

refactor: move test case to basic fixture

bfc4daf

pi0 merged commit 8adff2e into main Feb 17, 2022

pi0 deleted the fix/named-component-imports branch February 17, 2022 14:23

danielroe added the 3.x label Jan 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(nuxt3): generate imports for components with named exports correctly #3288

fix(nuxt3): generate imports for components with named exports correctly #3288

danielroe commented Feb 17, 2022 •

edited by pi0

Loading

netlify bot commented Feb 17, 2022 •

edited

Loading

pi0 Feb 17, 2022

pi0 Feb 17, 2022

fix(nuxt3): generate imports for components with named exports correctly #3288

fix(nuxt3): generate imports for components with named exports correctly #3288

Conversation

danielroe commented Feb 17, 2022 • edited by pi0 Loading

🔗 Linked issue

❓ Type of change

📚 Description

Notes

📝 Checklist

netlify bot commented Feb 17, 2022 • edited Loading

pi0 Feb 17, 2022

Choose a reason for hiding this comment

pi0 Feb 17, 2022

Choose a reason for hiding this comment

danielroe commented Feb 17, 2022 •

edited by pi0

Loading

netlify bot commented Feb 17, 2022 •

edited

Loading