Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt3): apply changes to meta tags and updateDOM accordingly #3271

Merged
merged 2 commits into from
Feb 16, 2022
Merged

fix(nuxt3): apply changes to meta tags and updateDOM accordingly #3271

merged 2 commits into from
Feb 16, 2022

Conversation

Diizzayy
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#13388, nuxt/nuxt#13387

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • fixes a bug where absolutely no meta changes (including on initial render) were applied while ssr: false.
  • allow changes to meta tags via useMeta or Meta Components to be properly applied after initial render. Meta tags were only applied on initial render, but were ignored on subsequent client-side navigation because updateDOM was never called again.

Resolves nuxt/nuxt#13388, nuxt/nuxt#13387

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Feb 16, 2022

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 6710d63

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/620d68e01f3bf9000761e31d

@pi0 pi0 requested a review from danielroe February 16, 2022 21:19
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you! ❀️

@pi0 pi0 merged commit ad52b79 into nuxt:main Feb 16, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useMeta and Dynamic Meta no longer working starting with: 3.0.0-27415318.ef69e74
3 participants