Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(bridge): add modules with hooks after all other modules #3239

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

danielroe
Copy link
Member

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It is otherwise impossible for modules to add their own auto imports or configure vite on a Bridge install.

@danielroe danielroe added bug Something isn't working bridge ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Feb 15, 2022
@danielroe danielroe requested a review from pi0 February 15, 2022 13:45
@danielroe danielroe self-assigned this Feb 15, 2022
@netlify
Copy link

netlify bot commented Feb 15, 2022

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 931f753

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/620c1f360b29710007b55f55

@Rigo-m
Copy link
Contributor

Rigo-m commented Feb 16, 2022

Is this a possible fix to this? nuxt-modules/storybook#359

@danielroe
Copy link
Member Author

@Rigo-m I don't think so - that looks like a different issue to me.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might introduce some flags to installModule later to make it easier :D

@pi0 pi0 merged commit 7c9b0a3 into main Feb 16, 2022
@pi0 pi0 deleted the fix/bridge-add-modules branch February 16, 2022 17:54
@ThomasBerne
Copy link

The seems to be still present in the 4.2.0 version. Has it been released ?

@ThomasBerne
Copy link

I checked the changes made to @nuxt/bridge and this error seems to occur even with the changes @danielroe did. Can we fix this ?

@danielroe
Copy link
Member Author

@ThomasBerne Would you raise a new issue? I don't believe the issued linked above was intended to be resolved by this PR.

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bridge bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants