This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt3): prevent removing and re-adding tags before mount #3212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#2419
β Type of change
π Description
This PR follows up on nuxt/nuxt#12980. The issue it solves occurs in the initial render cycle, if there are multiple
useMeta
tags for the same tag type, e.g.:In this case, immediately triggering
updateDOM
after the first call causes a mismatch because we haven't yet registered the second script tag yet, and so it's removed. It's then added back, triggering the rerun.By deferring updateDOM to mounted on the initial render, we give Vue a chance to process all these tags.
As a side effect, we are also more performant because we only trigger a single update, rather than a different one for every different
useMeta
call and meta tag we insert.π Checklist