Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(bridge): support addRouteMiddleware, navigateTo and abortNavigation #3193

Merged
merged 4 commits into from
Feb 15, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This aligns route middleware in Bridge with Nuxt 3, to make it easier for modules which are providing both Bridge + Nuxt 3 support.

It also resolves nuxt/nuxt#13361, by assuming if we have no nuxt instance we are being called in an async middleware.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request bridge 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Feb 11, 2022
@danielroe danielroe requested a review from pi0 February 11, 2022 11:58
@danielroe danielroe self-assigned this Feb 11, 2022
@netlify
Copy link

netlify bot commented Feb 11, 2022

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 84a2e62

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/6206503424f78c00085518d7

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested)

@pi0 pi0 merged commit 3c563fa into main Feb 15, 2022
@pi0 pi0 deleted the feat/add-route-middleware branch February 15, 2022 09:51
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bridge enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nuxt3]Β [Middleware] Unable to use useNuxtApp()/plugins in route middleware on the clientside
2 participants