Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(bridge): add support for useNuxt2Meta in plugins #3187

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

danielroe
Copy link
Member

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This allows us to call useNuxt2Meta in plugins when seeking to add metadata in Nuxt Bridge. Otherwise, authors would have to manually access ctx.app.head, etc.

Example can be found in https://github.com/nuxt-community/color-mode-module/pull/118/files#diff-2139019c09168a10222ac1ada5b0209112c5d2a5e1b4e761aaf948e742fcc323R14-R20.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request bridge labels Feb 11, 2022
@danielroe danielroe requested a review from pi0 February 11, 2022 10:35
@danielroe danielroe self-assigned this Feb 11, 2022
@netlify
Copy link

netlify bot commented Feb 11, 2022

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: d7d9c09

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/62063bec536a7900077fa3ad

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested)

@pi0 pi0 merged commit d046c96 into main Feb 15, 2022
@pi0 pi0 deleted the feat/bridge-plugin-meta branch February 15, 2022 09:50
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bridge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants