Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(app): use esm syntax for webpack module hot #316

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Conversation

danielroe
Copy link
Member

Docs: https://webpack.js.org/api/module-variables/#importmetawebpackhot

We could also add a check for whether module.hot exists and use whichever exists but we're moving into a strict esm world so 🤷.

resolves nuxt/nuxt#11073

@danielroe danielroe self-assigned this Jul 12, 2021
@danielroe danielroe added app bug Something isn't working labels Jul 12, 2021
@danielroe danielroe changed the title fix: use esm syntax for webpack module hot fix(app): use esm syntax for webpack module hot Jul 12, 2021
@danielroe danielroe requested a review from pi0 July 12, 2021 09:11
@pi0 pi0 merged commit 1bd0b74 into main Jul 12, 2021
@pi0 pi0 deleted the fix/module-hot-esm branch July 12, 2021 10:19
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x app bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError: module is not defined
2 participants