Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt3): add app:suspense:resolve hooks #2937

Merged
merged 3 commits into from
Jan 26, 2022
Merged

fix(nuxt3): add app:suspense:resolve hooks #2937

merged 3 commits into from
Jan 26, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jan 26, 2022 •
edited
Loading

🔗 Linked issue

resolves nuxt/nuxt#13301

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Our asyncData implementation was dependent on a hook being called within the pages module. This adds a similar hook at app level meaning that asyncData will work as expected on client-side.

Ideas for better hook naming welcome.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working nuxt3 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jan 26, 2022
@danielroe danielroe requested a review from pi0 January 26, 2022 16:25
@danielroe danielroe self-assigned this Jan 26, 2022
@netlify
Copy link

netlify bot commented Jan 26, 2022 •
edited
Loading

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: 2725886

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61f17ee26cbb7600072c7ee4

@danielroe danielroe changed the title fix(nuxt3): add app:start and app:finish hooks fix(nuxt3): add app:suspense:resolve hooks Jan 26, 2022
@danielroe @pi0
Update packages/nuxt3/src/app/bootstrap.ts
2725886 
Co-authored-by: pooya parsa <pyapar@gmail.com>
@pi0 pi0 merged commit 00e8a6e into main Jan 26, 2022
@pi0 pi0 deleted the fix/asyncdata-without-pages branch January 26, 2022 17:24
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working nuxt3 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"nuxt.isHydrating" remains "true" when not using "pages" folder
2 participants
@danielroe @pi0