Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): only apply relative url fix to css assets #2930

Merged
merged 1 commit into from
Jan 26, 2022
Merged

fix(vite): only apply relative url fix to css assets #2930

merged 1 commit into from
Jan 26, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#13286

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A bit embarrassing - we were converting binary files to string. I've also further restricted the relative url fix to .css files.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite 🔥 p5-urgent Priority 5: build-breaking bugs that affect most users and should be fixed ASAP labels Jan 26, 2022
@danielroe danielroe requested a review from pi0 January 26, 2022 12:39
@danielroe danielroe self-assigned this Jan 26, 2022
@netlify
Copy link

netlify bot commented Jan 26, 2022 •
edited
Loading

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: aadff42

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61f140ed748fc700078b1071

@danielroe danielroe marked this pull request as draft January 26, 2022 12:47
@danielroe danielroe marked this pull request as ready for review January 26, 2022 12:51
@pi0 pi0 merged commit d0bcc3f into main Jan 26, 2022
@pi0 pi0 deleted the fix/corrupted-assets branch January 26, 2022 12:59
@danielroe danielroe mentioned this pull request Jan 26, 2022
Closed
@replygirl replygirl mentioned this pull request Jan 19, 2023
Closed
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working 🔥 p5-urgent Priority 5: build-breaking bugs that affect most users and should be fixed ASAP vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

corrupted and missing assets in built vite app ('Failed to decode downloaded font')
2 participants
@danielroe @pi0