Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(kit): make resolvePath case-sensitive #291

Merged
merged 3 commits into from
Jun 30, 2021
Merged

fix(kit): make resolvePath case-sensitive #291

merged 3 commits into from
Jun 30, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 30, 2021 •
edited
Loading

The issue with App.vue reported in the linked issues is MacOS-specific and is caused in the playground by tryResolvePath resolving App.vue with app.vue (as existsSync returns true) and thereby generating the following entrypoint:

export { default } from './playground/App.vue'

This 'works' as MacOS is case-insensitive but it's not the correct path, hence HMR issue.

resolves nuxt/nuxt#10933, resolves nuxt/nuxt#10922

@danielroe danielroe self-assigned this Jun 30, 2021
@danielroe danielroe added bug Something isn't working kit labels Jun 30, 2021
@danielroe danielroe requested a review from pi0 June 30, 2021 13:28
@danielroe @pi0
fix: keep function private, and don't cache final exists call
c97c7ca 
Co-authored-by: pooya parsa <pyapar@gmail.com>
@pi0 pi0 merged commit 6cd5f88 into main Jun 30, 2021
@danielroe danielroe deleted the fix/app-hmr branch June 30, 2021 13:55
@atinux Volta.net
Copy link
Member

atinux commented Jun 30, 2021

This is awesome ✨

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vite HMR is broken on App.vue Webpack HMR is broken on app.vue
3 participants
@danielroe @atinux @pi0