Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt3): normalize page paths (for windows support) #2825

Merged
merged 1 commit into from
Jan 21, 2022
Merged

fix(nuxt3): normalize page paths (for windows support) #2825

merged 1 commit into from
Jan 21, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jan 20, 2022 •
edited
Loading

🔗 Linked issue

resolves nuxt/nuxt#13269

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

For Windows systems, we need to normalize paths (or escape \ characters) if users have insert their own un-normalised values.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working nuxt3 labels Jan 20, 2022
@danielroe danielroe requested a review from pi0 January 20, 2022 09:24
@danielroe danielroe self-assigned this Jan 20, 2022
@netlify
Copy link

netlify bot commented Jan 20, 2022 •
edited
Loading

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: d0c02a7

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61e92a5748d6f30008efd36a

@danielroe danielroe added the 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage label Jan 20, 2022
@pi0 pi0 merged commit d0d8e83 into main Jan 21, 2022
@pi0 pi0 deleted the fix/normalize-page-paths branch January 21, 2022 09:54
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working nuxt3 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pages:extend does not normalize page paths
2 participants
@danielroe @pi0