Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(bridge): set app.basePath #2808

Merged
merged 4 commits into from
Jan 19, 2022
Merged

fix(bridge): set app.basePath #2808

merged 4 commits into from
Jan 19, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/bridge#141

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We changed basePath to baseURL which is undefined in Nuxt Bridge - we'll need to update this PR too.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working nitro bridge labels Jan 19, 2022
@danielroe danielroe self-assigned this Jan 19, 2022
@netlify
Copy link

netlify bot commented Jan 19, 2022

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 23f6b64

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61e85972277d230008d63d52

@danielroe danielroe requested a review from pi0 January 19, 2022 11:16
packages/nitro/src/context.ts Outdated Show resolved Hide resolved
@danielroe danielroe changed the title fix(nitro): read app.basePath if it exists (for bridge) fix(bridge): set app.basePath Jan 19, 2022
@pi0 pi0 merged commit 6abf75d into main Jan 19, 2022
@pi0 pi0 deleted the fix/bridge-base-url branch January 19, 2022 19:10
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bridge bug Something isn't working nitro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error on fresh Nuxt Bridge project
2 participants