Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt3): pass nuxtApp to head() #2765

Merged
merged 1 commit into from
Jan 17, 2022
Merged

feat(nuxt3): pass nuxtApp to head() #2765

merged 1 commit into from
Jan 17, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#13260

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As it's quite tough to do much with a head() function without any context, this PR passes nuxtApp as an argument to head().

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request nuxt3 labels Jan 17, 2022
@danielroe danielroe requested a review from pi0 January 17, 2022 20:45
@danielroe danielroe self-assigned this Jan 17, 2022
@netlify
Copy link

netlify bot commented Jan 17, 2022 •
edited
Loading

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 0c20f8b

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61e5d54fa1faff00072a6fdc

@pi0 pi0 merged commit 0af0166 into main Jan 17, 2022
@pi0 pi0 deleted the feat/head-context branch January 17, 2022 20:52
@terion-name
Copy link

@danielroe @pi0 when will this be available? very urgently needed :(

@pi0
Copy link
Member

pi0 commented Jan 17, 2022

@terion-name It is already published :) Use npx nuxi upgrade --force to get the improvement.

@terion-name
Copy link

@pi0 both yarn add --dev nuxt3 and npx nuxi upgrade --force pull 3.0.0-27374221.e9d73f5, and it does not have this:

head(app) {
      console.log(app) // undefined
}

@danielroe
Copy link
Member Author

@terion-name That is the version immediately preceding the release with this feature.

@terion-name
Copy link

@danielroe https://www.npmjs.com/package/nuxt3:
3.0.0-27374221.e9d73f5 β€’ Public β€’ Published 35 minutes ago

seems nothing after it was published (

@danielroe
Copy link
Member Author

danielroe commented Jan 17, 2022 •
edited
Loading

The version you want is 3.0.0-27374221.0af0166. The hash matches the view here: https://github.com/nuxt/framework/commits/.

@terion-name
Copy link

@danielroe npm releases order was messed up:
Π‘Π½ΠΈΠΌΠΎΠΊ экрана 2022-01-17 Π² 23 43 38

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x enhancement New feature or request nuxt3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide context to head() method
3 participants
@danielroe @terion-name @pi0