Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(kit): support chainable extendRoutes in container #1966

Merged
merged 6 commits into from
Nov 16, 2021
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 16, 2021

πŸ”— Linked issue

ref: #1740, nuxt/bridge#183

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Allow chaining routes when using kit's legacy ModuleContainer
  • Separate extendRoutes and extendPages implementations

Caveats: For Nuxt3, chaining is still not supported anymore even when using legacy ModuleContainer (A warning will be emitted to show when skipping)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Nov 16, 2021

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 9e74f8a

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/6193bbd52e9f6f00083532ac

@pi0 pi0 merged commit 232fdd8 into main Nov 16, 2021
@pi0 pi0 deleted the fix/legacy-extend branch November 16, 2021 16:13
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants