This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): external modules under/esm/
pattern
#1949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ben bencodezen@users.noreply.github.com
π Linked issue
β Type of change
π Description
Found during pairing with @bencodezen π
To reproduce the bug (Vite):
which will cause the error of
export
is not a valid syntax. Searching down, the root cause is that the internal module ofdate-fns
been externalized but in a.js
format of ESM inserver.mjs
This PR adds the conversion to externalize modules under
/esm/
which I believe is a common pattern (date-fns
is using is at least).https://unpkg.com/browse/date-fns@2.25.0/esm/_lib/protectedTokens/index.js
π Checklist