Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(bridge): ensure vue ts alias points to original vue #1924

Merged
merged 4 commits into from
Nov 15, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 15, 2021

πŸ”— Linked issue

resolves nuxt/bridge#193, resolves nuxt/bridge#215

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Context: #1861. This PR removes any rewriting of vue import (which would otherwise be circular).

Together with adding the following to ~~/tsconfig.json, type inference is working for me with Volar:

{
    "extends": "./.nuxt/tsconfig.json",
    "vueCompilerOptions": {
        "experimentalCompatMode": 2,
    }
}

Note that Volar doesn't seem to pick this up if it's added to .nuxt/tsconfig.json.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • Add note to docs
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working bridge labels Nov 15, 2021
@danielroe danielroe requested a review from pi0 November 15, 2021 13:20
@danielroe danielroe self-assigned this Nov 15, 2021
@netlify
Copy link

netlify bot commented Nov 15, 2021

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 6f6c112

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61927249a1e44f00089f4be1

@pi0 pi0 merged commit 4b367a1 into main Nov 15, 2021
@pi0 pi0 deleted the fix/bridge-vue-import branch November 15, 2021 15:58
@baixiaoyu2997
Copy link
Contributor

baixiaoyu2997 commented Nov 16, 2021

I have discussed type issue here before,It seems that other people are not interested 😭
https://github.com/nuxt/framework/discussions/1773#discussion-3672217

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bridge bug Something isn't working
Projects
None yet
4 participants