Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

refactor(nuxt3): use the @nuxt/kit template utilites #1908

Merged
merged 1 commit into from
Nov 15, 2021
Merged

refactor(nuxt3): use the @nuxt/kit template utilites #1908

merged 1 commit into from
Nov 15, 2021

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Nov 14, 2021

🔗 Linked issue

N/A

❓ Type of change

This PR is refactoring.

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When I was reading the nuxt3 codes about how to extend dynamic routing, I noticed that template utils are duplicated.

I changed to use the @nuxt/kit, so we didn’t need the packages/nuxt3/src/core/template.utils.ts, I removed it.

If packages/nuxt3/src/core/template.utils.ts is there for a reason, it is all right to close this PR. :)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Nov 14, 2021 •
edited
Loading

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: 589b6c9

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61909f298897ec00084a5080

pi0
pi0 approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It makes sense to remove duplicate code. However please do not directly use template tips from kit :D It is internal and can change unnoticed

@pi0 pi0 merged commit c53b6a5 into nuxt:main Nov 15, 2021
@kazupon kazupon deleted the refactor/nuxt3-1 branch November 16, 2021 04:24
@kazupon
Copy link
Member Author

kazupon commented Nov 16, 2021

It is internal and can change unnoticed

Okay! I got it! :)

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kazupon @pi0 @danielroe