-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Conversation
βοΈ Deploy Preview for nuxt3-docs canceled. π¨ Explore the source changes: 9e35588 π Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61923582e53c6a000757d53a |
It would be nice to implement for Nuxt3 before closing linked issue since:
(We can do above in another PR π) |
Added the mock for Nuxt 3, not sure what's the best place to set the alias, feel free to modify. Also converting to draft for now, I will need to do some tests for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ping when done testing @antfu (we can always improve by trying edge releases too :D)
Love your changes! However I guess this is a bit tricky, in my testing, our mock does not take effects for optimizeDeps: {
exclude: [
'@vueuse/core',
'@vueuse/shared',
'vue-demi'
],
} I don't think it's flexible as we can't possibly list all the packages that use
|
Good points @antfu! Well indeed this mocking solution only works for transpired dependencies to mitigate compatibility issues and certainly, we cannot prevent all problematic cases. (however, there is now a escape path :D) It makes sense to include Regarding pinna's Nuxt module, I made a rewrite PR (vuejs/pinia#791) that splits the vue2 plugin from vue3. But I can see for |
That makes sense. Then I think we could merge it and I will do the exclusion on VueUse. |
π Linked issue
Close nuxt/bridge#201
β Type of change
π Description
I think it's safe to only mock for bridge since in Vue 3
vue-demi
is simply some redirection without side effects.Todo: (@pi0)
@vuejs/composition-api
for nuxt3isVue2
andisVue3
)π Checklist