fix(vite): expose underlying import errors #1696

danielroe · 2021-11-04T13:54:16Z

🔗 Linked issue

See nuxt/nuxt#11996

❓ Type of change

📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality like performance)
✨ New feature (a non-breaking change that adds functionality)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The current error message when loading externals is:

(node:31884) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
Unexpected token 'export'
  at wrapSafe (internal/modules/cjs/loader.js:1001:16)  
  at Module._compile (internal/modules/cjs/loader.js:1049:27)  
  at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)  
  at Module.load (internal/modules/cjs/loader.js:950:32)  
  at Function.Module._load (internal/modules/cjs/loader.js:790:14)  
  at ModuleWrap.<anonymous> (internal/modules/esm/translators.js:199:29)  
  at ModuleJob.run (internal/modules/esm/module_job.js:169:25)  
  at async Loader.import (internal/modules/esm/loader.js:177:24)  
  at async __instantiateModule__ (file://./playground/.nuxt/dist/server/server.mjs:7515:3)

This doesn't reveal anything about the underlying cause or package, and can be very confusing.

This PR changes the logging to the following:

(node:33676) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/v-tooltip/node_modules/@popperjs/core/lib/enums.js:1
export var top = 'top';
^^^^^^

SyntaxError: Unexpected token 'export'
    at wrapSafe (internal/modules/cjs/loader.js:1001:16)
    at Module._compile (internal/modules/cjs/loader.js:1049:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:14)
    at ModuleWrap.<anonymous> (internal/modules/esm/translators.js:199:29)
    at ModuleJob.run (internal/modules/esm/module_job.js:169:25)
    at async Loader.import (internal/modules/esm/loader.js:177:24)
    at async __instantiateModule__ (file:///Users/daniel/code/nuxt/framework/playground/.nuxt/dist/server/server.mjs:7515:3)

Error loading external "/v-tooltip/node_modules/@popperjs/core/lib/enums.js".
  at file://./playground/.nuxt/dist/server/server.mjs:3704:283  
  at async __instantiateModule__ (file://./playground/.nuxt/dist/server/server.mjs:7515:3)

And the message displayed in the browser is, which is more relevant:

Error loading external "/v-tooltip/node_modules/@popperjs/core/lib/enums.js".
  at file://./playground/.nuxt/dist/server/server.mjs:3704:283  
  at async __instantiateModule__ (file://./playground/.nuxt/dist/server/server.mjs:7515:3)

📝 Checklist

I have linked an issue or discussion.
I have updated the documentation accordingly.

netlify · 2021-11-04T13:54:23Z

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: add1284

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/618423eee8a2510008a71187

packages/vite/src/dev-bundler.ts

fix(vite): expose underlying import errors

c5a321c

danielroe added dx vite labels Nov 4, 2021

danielroe requested a review from pi0 November 4, 2021 13:54

danielroe self-assigned this Nov 4, 2021

danielroe mentioned this pull request Nov 4, 2021

SyntaxError: Unexpected token 'export' nuxt/nuxt#11996

Closed

pi0 reviewed Nov 4, 2021

View reviewed changes

packages/vite/src/dev-bundler.ts Outdated Show resolved Hide resolved

Update packages/vite/src/dev-bundler.ts

add1284

pi0 merged commit 6f1f12a into main Nov 4, 2021

pi0 deleted the fix/expose-esm-error branch November 4, 2021 18:18

danielroe added the 3.x label Jan 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(vite): expose underlying import errors #1696

fix(vite): expose underlying import errors #1696

danielroe commented Nov 4, 2021

netlify bot commented Nov 4, 2021 •

edited

Loading

fix(vite): expose underlying import errors #1696

fix(vite): expose underlying import errors #1696

Conversation

danielroe commented Nov 4, 2021

🔗 Linked issue

❓ Type of change

📚 Description

📝 Checklist

netlify bot commented Nov 4, 2021 • edited Loading

netlify bot commented Nov 4, 2021 •

edited

Loading