Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): remove conflicting vite aliases #1624

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix(vite): remove conflicting vite aliases #1624

merged 1 commit into from
Nov 2, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 1, 2021

πŸ”— Linked issue

partly solves nuxt/nuxt#12657
resolves nuxt/nuxt#11985

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR removes some unused vite aliases which conflict with directory names when present (/app and /build). I can't find any indication these are used but please correct me if I'm wrong.

I've removed ~ and @ too as these should be defined in nuxt.options.alias but if this was a workaround or I have misunderstood the purpose of this please do let me know (cc @pi0).

It also fixes the warmup command for vite. (Previously this was actually not doing anything as there was no route resolved for it.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite bridge labels Nov 1, 2021
@danielroe danielroe requested review from pi0 and antfu November 1, 2021 13:46
@danielroe danielroe self-assigned this Nov 1, 2021
@netlify
Copy link

netlify bot commented Nov 1, 2021

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 6cb95b8

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/617fefae4b371b00074c39f6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bridge bug Something isn't working vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building a Nuxt 3 app inside Docker
2 participants