Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

chore(nuxt3): add tests, comments and example for components scan #1455

Merged
merged 13 commits into from
Nov 15, 2021
Merged

chore(nuxt3): add tests, comments and example for components scan #1455

merged 13 commits into from
Nov 15, 2021

Conversation

flozero
Copy link
Contributor

@flozero flozero commented Oct 26, 2021

🔗 Linked issue

nuxt/nuxt#11067

❓ Type of change

Adding some comments docs and add unit tests for scanComponents

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

close nuxt/nuxt#11067

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@flozero flozero marked this pull request as draft October 26, 2021 02:38
@netlify
Copy link

netlify bot commented Oct 26, 2021 •
edited
Loading

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: 744bb53

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61925cbeefae030008a5d691

@flozero
Copy link
Contributor Author

flozero commented Oct 26, 2021 •
edited
Loading

Still a WIP as I am step by step understanding what this scanComponent is doing. Any feedbacks on my comments are more than welcome

@pi0 pi0 changed the title understand better scan components adding some comments docs: improve components example and internal comments Nov 15, 2021
@pi0 pi0 marked this pull request as ready for review November 15, 2021 12:10
@pi0 pi0 changed the title docs: improve components example and internal comments chore(nuxt3): add tests, comments and example for components scan Nov 15, 2021
@pi0 pi0 merged commit 6b873f1 into nuxt:main Nov 15, 2021
@flozero
Copy link
Contributor Author

flozero commented Nov 15, 2021

Sorry Didn't had time to come back on this as I wanted to understand a bit better. Thanks for adding the missing part @pi0 ! It helps me a lot to understand

@flozero flozero deleted the feat/scanComponent-tests branch November 15, 2021 16:24
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 left review comments

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unit tests for components
3 participants
@flozero @pi0 @danielroe