Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go to definition on windows #141

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

gaetschwartz
Copy link
Contributor

Fixes #138

@fdncred
Copy link
Collaborator

fdncred commented Jun 22, 2023

oh, ya. that looks much better. thanks! i'll try to test and play with it later this afternoon!

@fdncred
Copy link
Collaborator

fdncred commented Jun 22, 2023

I don't have a problem landing this but I think it's pinpointed another bug.
In this file, I can "Go To Definition" on line 40 with get-target-dependencies but I can't do it on line 58 for find-deps. There could be a bug in nushell or something else. If you have time, it would be a big help to figure out what's going on.

https://github.com/nushell/nu_scripts/blob/d48ce0b6c1ea1c4c531d9f4f37be9f51aa3672f4/make_release/nu_deps.nu#L58-L59

@fdncred fdncred merged commit 7caaad1 into nushell:main Jun 23, 2023
@gaetschwartz gaetschwartz deleted the fix-go-to-definition-on-windows branch June 24, 2023 09:59
@gaetschwartz
Copy link
Contributor Author

@fdncred Are you still experience this issue ? It works on my end ?

Desktop.2023.06.24.-.12.08.46.01.mp4

@fdncred
Copy link
Collaborator

fdncred commented Jun 24, 2023

It's working now because i fixed the script. If you change the line to the way it was when I reported it let deps = find-deps it won't work. But if you make it let deps = (find-deps) it works fine. The first way is invalid nushell even though our validator doesn't detect it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Going to definition prepends \\ to the file path in Windows
2 participants