Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CI coverage until we can figure out why it's broken #8677

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

sophiajt
Copy link
Contributor

Description

The coverage testing on CI has been broken for at least a week. It looks like we might have to do some work, but for now, disabling it so we don't give bad stability info to contributors.

User-Facing Changes

(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass
  • cargo run -- crates/nu-utils/standard_library/tests.nu to run the tests for the standard library

Note
from nushell you can also use the toolkit as follows

use toolkit.nu  # or use an `env_change` hook to activate it automatically
toolkit check pr

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@sophiajt sophiajt merged commit 0e496f9 into nushell:main Mar 30, 2023
@sophiajt sophiajt deleted the remove_coverage branch March 30, 2023 17:49
sholderbach added a commit to sholderbach/nushell that referenced this pull request Apr 12, 2023
sophiajt pushed a commit that referenced this pull request Apr 13, 2023
# Description
Let's see if we don't run out of disk space as quickly again

This reverts commit 0e496f9.
(#8677)



# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting

Same coverage setup as before
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant