Replace std::time::Instant
with web_time::Instant
#14668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
std::time::Instant
type panics in the WASM context. To prevent this, I replaced all uses ofstd::time::Instant
in WASM-relevant crates withweb_time::Instant
. This ensures commands usingInstant
work in WASM without issues. For non-WASM targets,web-time
simply reexportsstd::time
, so this change doesn’t affect regular builds (docs).To ensure future code doesn't reintroduce
std::time::Instant
in WASM contexts, I added aclippy wasm
command to the toolkit. This runscargo clippy
with aclippy.toml
configured to disallowstd::time::Instant
. Sinceweb-time
aliasesstd::time
by default, theclippy.toml
is stored inclippy/wasm
and is only loaded when targeting WASM. I also added a new CI job that tests this too.User-Facing Changes
None.
Tests + Formatting
toolkit fmt
toolkit clippy
toolkit test
toolkit test stdlib
After Submitting