Add bytes split command
#14652
Merged
Add bytes split command
#14652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdncred
reviewed
Dec 21, 2024
fdncred
reviewed
Dec 21, 2024
fdncred
added
wait-until-after-nushell-release
new-command
pr:commands
|
please fix the conflicts and we can land this |
|
It's ready |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10708
Description
Add
bytes splitcommand.bytes splitsplits its input on the provided separator on binary values and binary streams without collecting. The separator can be a multiple character string or multiple byte binary.It can be used when neither
split row(not streaming over raw input) norlines(streaming, but can only split on newlines) is right.The backing iterator implemented in this PR,
SplitRead, can be used to implement a streamingsplit rowin the future.User-Facing Changes
bytes splitcommand added, which can be used to split binary values and raw streams using a separator.Tests + Formatting
After Submitting
Mention in release notes.