Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary input support to chunks #14649

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Add binary input support to chunks #14649

merged 2 commits into from
Dec 25, 2024

Conversation

Bahex
Copy link
Contributor

@Bahex Bahex commented Dec 21, 2024

Description

Adds support for Value::Binary and ByteStream inputs to chunks.
In case of ByteStream, stream is not collected, and chunked as it comes.

This works:

open --raw /dev/urandom | chunks 4 | take 4

User-Facing Changes

chunks can now be used on binary values and streams.

Tests + Formatting

  • 🟢 toolkit fmt
  • 🟢 toolkit clippy
  • 🟢 toolkit test
  • 🟢 toolkit test stdlib

After Submitting

N/A

@fdncred fdncred added wait-until-after-nushell-release streaming Issues related to streaming data (or collecting data when it should be streamed) pr:commands This PR changes our commands in some way labels Dec 21, 2024
@fdncred fdncred merged commit f2dcae5 into nushell:main Dec 25, 2024
14 checks passed
@github-actions github-actions bot added this to the v0.102.0 milestone Dec 25, 2024
@Bahex Bahex mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:commands This PR changes our commands in some way streaming Issues related to streaming data (or collecting data when it should be streamed) wait-until-after-nushell-release
Projects
None yet
Milestone
v0.102.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Bahex @fdncred