Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #481 #491

Merged
merged 1 commit into from
May 10, 2021
Merged

Fixes #481 #491

merged 1 commit into from
May 10, 2021

Conversation

arjunguha
Copy link
Member

No description provided.

@arjunguha
Copy link
Member Author

arjunguha commented May 10, 2021

@jpolitz I am going to merge in this patch. It fixes a bug in Stopify that @LeifAndersen identified (#481). I do not believe it breaks anything else. But, do look at the two unit tests that I've added -- one that still fails

The problem would arise when stopifying a var within a block or loop at the top-level. For various reasons, ElementaryJS does wraps the entire student code in a thunk, so student code would never update top-level variables, which is why this problem would never arise Ocelot.

@arjunguha arjunguha merged commit de1d662 into master May 10, 2021
@arjunguha arjunguha deleted the fix-481 branch May 10, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant