Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #4887 #4891

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix for issue #4887 #4891

merged 1 commit into from
Nov 26, 2024

Conversation

OsirisTerje
Copy link
Member

Fixes #4887

Copy link
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OsirisTerje

I suppose my initial hesitation to just bumping this was the unknown of if we would have to bump it again with the next release of System.Memory. That said, it's been about 2 years between releases for System.Memory, and 6 years since the last minor version bump (if that factors in) so perhaps that is a problem for another time

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@stevenaw
Copy link
Member

@OsirisTerje I'm going to go ahead and merge this as well as both @manfred-brands and I have approved.

Thanks again for your fix here.

@stevenaw stevenaw merged commit f597da8 into main Nov 26, 2024
5 checks passed
@stevenaw stevenaw deleted the Issue4887 branch November 26, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileLoadException for NUnit 4.2.2 when upgrade the System.Buffers to 4.6.0
3 participants