Added EqualTimeBaseConstraint #4853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OsirisTerje
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
This makes sense to me. AFAICS the Equal constraints have to separate for at least 1) each group of primitive types (Numeric, Date/Time, bools, char/strings), where the groups often have things in common and then 2) when the types within the group differs in such a way it is better to seperate there too. So to me this is on the right way.
|
@manfred-brands All three EqualTo..... PRs are approved. Do you want to do more changes, or can they be merged ? |
|
@OsirisTerje I think I extracted the common .Using in a base class, but cannot remember if all branches use that. I need to check/ensure that. |
|
Due to merge conflicts superseded by combined PR #4882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third PR working towards #53 and Related to #4847 and #4848
This constraint use classes (EqualTimeBasedConstraintWithNumericTolerance) to limit in what cases we can specify the
.Secondsetc. modifiers.So we allow:
Assert.That(date1, Is.EqualTo(date2).Within(3).Seconds);but not:
Assert.That(date1, Is.EqualTo(date2).Seconds)nor:
Assert.That(date1, Is.EqualTo(date2).Within(timeSpan).Seconds)Because the class with tolerance is different than the one without this also doesn't allow repeats like:
Assert.That(date1, Is.EqualTo(date2).Within(1).Hours.Seconds.Within(3))Fixes #4877