Allow paragraph-wise translations #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add configuration option to translate document paragraph-wise
instead of line-wise (disabled by default)
- add stub for paragraph identification function
- refactor main plugin class to consider configuration variable both
during POT creation and during translation
- paragraph-wise translation does not work yet, only stubs exist
- current implementation maintains full backward compatibility
|
I've tested the PR with python3, both in line-wise (old-style) mode and paragraph-wise. If you like these changes, I would appreciate if you could release a new version. |
pjgrizel
approved these changes
Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings paragraph-wise translations while maintaining full backward-compatibility to previous versions. It also adds a configuration option to enable this behaviour.