Dev kun #30
Merged
Dev kun #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iintSjds
reviewed
Oct 24, 2022
src/meshes/reduced_uiniform_map.jl
Outdated
| @assert !isempty(symmetries) # Identity has to be always present. | ||
| _kgrid_size = ones(Int, DIM) | ||
| _kgrid_size[1:DIM] = kgrid_size[1:DIM] | ||
| _kshift = kshift ? [1 // 2, 1 // 2, 1 // 2] : [0, 0, 0] |
Codecov Report
@@ Coverage Diff @@
## dev #30 +/- ##
===========================================
+ Coverage 31.58% 43.32% +11.73%
===========================================
Files 19 20 +1
Lines 1143 1198 +55
===========================================
+ Hits 361 519 +158
+ Misses 782 679 -103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
need to treat kshift cautiously.
Uniformbzmesh
iintSjds
reviewed
Oct 25, 2022
| return klinearidx | ||
| end | ||
|
|
||
| function reduced_uniform_meshmap(model::UniformKMeshSym.Model, dim; kgrid_size::Vector{Int}) |
iintSjds
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add _reduced_uniform_meshmap for even and odd kgrid size, and with or without shift
Add integration test for DFTK symmetrized mesh .
Closes #26