Minor fixes #90
Merged
Minor fixes #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2020 14:07
Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
AFAICT in the git history, numa_preferred would never return -1. So the existing logic is unnecessary. Replace it with simpler logic. Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
andikleen
requested changes
Jun 19, 2020
|
It would. My thought on it was that kernel was released 8 years ago and the breakage for people would be minimal. It's certainly fine to not accept that. There's a couple other minor changes too though. If you're so inclined to check my prefer-many branch, I do auto detection of the new uapi. |
|
On Thu, Jun 18, 2020 at 06:56:03PM -0700, Ben Widawsky wrote:
It would. My thought on it was that kernel was released 8 years ago and the
breakage for people would be minimal. It's certainly fine to not accept that.
There's a couple other minor changes too though.
Yes I prefer to not break them unless there's a good reason. Minor
readability improvements ain't one.
The other changes are fine, please submit without this one
If you're so inclined to check my prefer-many branch, I do auto detection of
the new uapi.
Good.
…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.*
|
bwidawsk
force-pushed
the
prep-prefer-many
branch
from
c71a309 to
276d38e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some minor fixes/improvements I made in preparation for a larger series which isn't yet ready for a PR.